Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the PR-close GitHub Actions workflow to allow cleanup_name to be specified as multiple newline-separated values, enabling multiple label-based OpenShift cleanup passes in a single run.
Changes:
- Documented that
cleanup_namesupports newline-separated multi-value input. - Updated the OpenShift label cleanup step to iterate over each
cleanup_nameline and runoc deleteper name.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DerekRoberts
force-pushed
the
feat/cleanup-name-multi-value
branch
from
3905769 to
af58392
Compare
DerekRoberts
force-pushed
the
feat/cleanup-name-multi-value
branch
4 times, most recently
from
0575533 to
d51dd4b
Compare
Allow cleanup_name to accept space-separated strings so multiple label-based cleanup passes can run in a single PR close workflow. When cleanup_name is not provided (empty default), falls back to the original behavior using the repository name.
DerekRoberts
force-pushed
the
feat/cleanup-name-multi-value
branch
from
d51dd4b to
10a32c3
Compare
DerekRoberts
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow
cleanup_nameto accept newline-separated strings so multiple label-based cleanup passes can run in a single PR close workflow.Changes
cleanup_namedescription to document newline-separated multi-value supportOC Template (label) Cleanupstep now loops over each name, matching the existingremove_pvcpatternBackwards Compatible
Single-value callers are unaffected — the loop runs once, same behaviour as before.
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: