Skip to content

test: add label cleanup coverage to pr-open workflow#234

Merged
DerekRoberts merged 9 commits intomainfrom
chore/ci/labelTests
Mar 4, 2026
Merged

test: add label cleanup coverage to pr-open workflow#234
DerekRoberts merged 9 commits intomainfrom
chore/ci/labelTests

Conversation

@DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Mar 3, 2026

Summary

Adds test coverage for .pr-close.yml using cleanup: label.

Three new jobs in pr-open.yml:

  • label-setup: creates a ConfigMap labeled app=quickstart-openshift-helpers-<PR#> and verifies it exists
  • label-cleanup: calls .pr-close.yml with cleanup: label only — no cleanup_name, exercising the default (repo name)
  • label-verify: confirms no resources remain with that label after cleanup; fails if any are found

results job updated to gate on label-verify.


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copilot AI review requested due to automatic review settings March 3, 2026 23:17
@DerekRoberts DerekRoberts requested a review from mishraomp as a code owner March 3, 2026 23:17
@DerekRoberts DerekRoberts self-assigned this Mar 3, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the PR-open GitHub Actions workflow to add coverage for the reusable .pr-close.yml workflow’s label-based cleanup path by creating a labeled OpenShift resource, invoking cleanup, and verifying deletion.

Changes:

  • Add label-setup, label-cleanup, and label-verify jobs to exercise .pr-close.yml with cleanup: label (no cleanup_name override).
  • Create a labeled ConfigMap in OpenShift and verify it exists pre-cleanup.
  • Gate the results job on label-verify to ensure cleanup verification is part of the workflow outcome.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@DerekRoberts DerekRoberts moved this from New to Active in DevOps (NR) Mar 3, 2026
@DerekRoberts DerekRoberts merged commit b5621fb into main Mar 4, 2026
22 checks passed
@DerekRoberts DerekRoberts deleted the chore/ci/labelTests branch March 4, 2026 00:58
@github-project-automation github-project-automation bot moved this from Active to Done in DevOps (NR) Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants