test: add label cleanup coverage to pr-open workflow#234
Merged
DerekRoberts merged 9 commits intomainfrom Mar 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the PR-open GitHub Actions workflow to add coverage for the reusable .pr-close.yml workflow’s label-based cleanup path by creating a labeled OpenShift resource, invoking cleanup, and verifying deletion.
Changes:
- Add
label-setup,label-cleanup, andlabel-verifyjobs to exercise.pr-close.ymlwithcleanup: label(nocleanup_nameoverride). - Create a labeled ConfigMap in OpenShift and verify it exists pre-cleanup.
- Gate the
resultsjob onlabel-verifyto ensure cleanup verification is part of the workflow outcome.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds test coverage for
.pr-close.ymlusingcleanup: label.Three new jobs in
pr-open.yml:label-setup: creates a ConfigMap labeledapp=quickstart-openshift-helpers-<PR#>and verifies it existslabel-cleanup: calls.pr-close.ymlwithcleanup: labelonly — nocleanup_name, exercising the default (repo name)label-verify: confirms no resources remain with that label after cleanup; fails if any are foundresultsjob updated to gate onlabel-verify.Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: