Conversation
There was a problem hiding this comment.
nit: other modules are singular, perhaps we could rename this field.py
| def _build_lapse_rate_field( | ||
| actuals: List[SFMSDailyActual], attribute: str, lapse_rate: float, label: str | ||
| ) -> ScalarField: | ||
| lats = np.array([a.lat for a in actuals], dtype=np.float32) |
There was a problem hiding this comment.
We should probably do the _VALID_SFMS_ATTRIBUTES check here too.
|
|
||
|
|
||
| def build_wind_vector_field(actuals: List[SFMSDailyActual]) -> WindVectorField: | ||
| valid = [s for s in actuals if s.wind_speed is not None and s.wind_direction is not None] |
There was a problem hiding this comment.
We should probably do the _VALID_SFMS_ATTRIBUTES check here too.
There was a problem hiding this comment.
I think we can remove this file and all the sources since the methods have been pulled out to the build_* functions.
|
| y_size = ref_ds.ds.RasterYSize | ||
|
|
||
| with WPSDataset(mask_path) as mask_ds: | ||
| valid_mask = ref_ds.apply_mask(mask_ds.warp_to_match(ref_ds)) |
There was a problem hiding this comment.
Does the mask_ds always need to be reprojected?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5200 +/- ##
==========================================
+ Coverage 68.90% 68.91% +0.01%
==========================================
Files 392 392
Lines 16373 16382 +9
Branches 1846 1848 +2
==========================================
+ Hits 11281 11290 +9
Misses 4508 4508
Partials 584 584 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
grid.pyfields.pysfms_daily_actuals.pyTest Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireCalc
FireCalc bookmark
Auto Spatial Advisory (ASA)
HFI Calculator
SFMS Insights
Fire Watch