Open
Conversation
Anusree-J
reviewed
Feb 17, 2026
Contributor
Anusree-J
left a comment
There was a problem hiding this comment.
Some comments:
- Seems like https://naesb.org/espi/ is not an open URL; schema validation will fail
- Terms like serviceKind, intervalBlocks, intervalBlock are mapped to class IRIs (espi:ServiceKind, espi:IntervalBlock) instead of property IRIs. In JSON-LD, context terms must map to properties, not
classes. Fix mappings to use the correct property IRIs (e.g., meter:serviceKind, meter:intervalBlocks). - Fix coveragePeriod structure mismatch
- attributes.yaml defines coveragePeriod with start + end
- vocab.jsonld declares its range as meter:DateTimeInterval
- But DateTimeInterval (from Green Button) uses start + duration, not start + end
- credential subject id is seperate from DID - i think we used customer id in other VCs
intervalBlockscan be moved underreadingTypeinstead ofcredentialSubject- do we need interval length since we have interval blocks?
- Little confused about the reasoning behind keeping value as int and having powerOfTenMultiplier property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #185
Title: Add Meter Data Verifiable Credential schema (Green Button aligned)
Body:
Summary
time-series interval meter readings (e.g., 15-min kWh data)
external/schema/green-button/with human-readable string enums mapped toESPI integer codes
trading apps for single-meter demand forecasting
New files
external/schema/green-button/attributes.yamlReadingType,IntervalBlock,IntervalReading,DateTimeInterval, and 5 ESPI enumerationsenergy-credentials/meter-data-vc/attributes.yamlMeterDataCredentialschema with$reflinks to Green Button typesenergy-credentials/meter-data-vc/context.jsonldespi:andschema:namespacesenergy-credentials/meter-data-vc/vocab.jsonld@graphwithrdfs:Classandrdf:Propertydefinitions)energy-credentials/meter-data-vc/example.jsonenergy-credentials/meter-data-vc/readme.mdModified files
energy-credentials/readme.md— added credential to table, directory tree, relationship diagram, issuance scenariosValidation
openapi-spec-validator(OpenAPI 3.1.1)$refpaths (4 internal, 3 external) resolve correctlyexample.jsonconforms to schema (all required fields, valid enums, consistent intervals)