Skip to content

Validating PULSE Specification against the Beckn Core specification v 1.1.0, validating examples against the updated PULSE specification#25

Open
rajaneeshk90 wants to merge 7 commits intobeckn:draftfrom
rajaneeshk90:draft
Open

Validating PULSE Specification against the Beckn Core specification v 1.1.0, validating examples against the updated PULSE specification#25
rajaneeshk90 wants to merge 7 commits intobeckn:draftfrom
rajaneeshk90:draft

Conversation

@rajaneeshk90
Copy link

@rajaneeshk90 rajaneeshk90 commented Mar 18, 2024

Problem:
The example JSON are not consistent with the specification. For instance:

  • In on_search the message.provider is outside the message.catalog. As per the specification, it should be inside the message.catalog object.
  • Inconsistent Ids are used across the examples for order_id and agent_Id. They should be consistent across the examples.

The details of the issue can be found in this issue page: #24

Changes made:

  • Moved the message.provider inside the message.catalog object of the on_search json.
  • Made the order_id and agen_id consistent across all APIs.

Related ticket: beckn/beckn-ui-workspace#483

@emmayank
Copy link
Contributor

HI @rajaneeshk90 ,

I have reviewed your PR. please find the observations below and make the necessary change.

  1. /Init ( example) - message.item[0].xinput - Schema is incorrect
  2. /confirm ( example) - message.item[0].xinput - Schema is incorrect
  3. /rating (example) - rating value is missing
  4. /support (example) - support schema is incorrect
  5. /on_rating(example) - schema is incorrect
  6. /on_support(example) - schema is incorrect

Thanks
@emmayank

@rajaneeshk90
Copy link
Author

Hi @emmayank

Thanks for reviewing the PR.
I have made the suggested changes, please have a look.

@rajaneeshk90 rajaneeshk90 changed the title Making the example JSON consistent with the PULSE specification Validating PULSE Specification against the Beckn Core specification v 1.1.0 Apr 15, 2024
@rajaneeshk90 rajaneeshk90 changed the title Validating PULSE Specification against the Beckn Core specification v 1.1.0 Validating PULSE Specification against the Beckn Core specification v 1.1.0, validating examples against the updated PULSE specification Apr 15, 2024
@emmayank emmayank requested a review from ravi-prakash-v April 16, 2024 06:33
@rajaneeshk90 rajaneeshk90 linked an issue May 7, 2024 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validating PULSE Specification with Core v 1.1.0

2 participants