Skip to content

Persistent session support#118

Open
pavlushkin wants to merge 6 commits intomasterfrom
persistent-session-support
Open

Persistent session support#118
pavlushkin wants to merge 6 commits intomasterfrom
persistent-session-support

Conversation

@pavlushkin
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0467a84) 97.48% compared to head (24812a6) 97.50%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   97.48%   97.50%   +0.01%     
==========================================
  Files           8        8              
  Lines         717      722       +5     
==========================================
+ Hits          699      704       +5     
  Misses         18       18              
Flag Coverage Δ
unittests 97.50% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruscoder
Copy link
Member

Good feature. I suggest actualize it and get it merged. The only thing that looks confusing to me is naming - http_session, I suggest renaming it to just session or aiohttp_session or client_session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants