change stale timing

[kaitozaw]

Pull Request

Category

GitHub Workflow

Feature/Issue Description

Q: Please give a brief summary of your feature/fix
A: Changed the stale issue duration from 14 days to 4 months (120 days) to give issues more time before being marked as stale.

Q: Give a technical rundown of what you have changed (if applicable)
A:

• Updated days-before-stale from 14 to 120 days
• Updated days-before-close from 11 to 7 days to match the stale message
• Fixed typo in stale-issue-message: "This issue as been" → "This issue has been"

[zinduolis]

PR Review: #3507 - Change Stale Timing

Status: Changes Requested (Migration Recommended)

Review Summary

The proposed changes to timing (120 days stale, 7 days close) in stale.yml are good. However, this workflow is currently using actions/stale@v5, which relies on deprecated Node.js 12/16 runtimes. This will cause warnings and eventually fail.

⚠️ Critical Issue: Deprecated Version

The current version v5 is obsolete. We should take this opportunity to migrate to v10 (latest), which uses supported Node version.

Migration Checklist (v5 → v10)

To migrate stale.yml to v10, please make the following updates:

1. Update Version Tag:

   • Change actions/stale@v5 to actions/stale@v10.
   • Security Recommendation: Pin to a full commit SHA instead of a tag to prevent supply-chain attacks.
     ```yaml
     uses: actions/stale@28ca103 # v10.0.0
     ```

2. Rename Parameter:

   • `exempt-milestones` is deprecated in v10 for the "all" behavior.
   • Change `exempt-milestones: true` to `exempt-all-milestones: true`.

3. Update Date Format:

   • v10 is stricter with date formats (ISO 8601 required).
   • Change `start-date: '2022-06-15'` to `start-date: '2022-06-15T00:00:00Z'`.

[zinduolis]

Test Configuration

The stale.yml workflow was modified for local validation with the following changes:

• Trigger: Added workflow_dispatch to allow manual execution.
• Safety: Enabled debug-only: true to prevent actual changes (closing/labelling) to live issues/PRs.

Execution

The test was run locally using act to simulate the GitHub Actions environment:
act workflow_dispatch -W .github/workflows/stale.yml --secret GITHUB_TOKEN=$(gh auth token)

Results

• Status: ✅ PASSED
• Validation:
  • The workflow successfully authenticated with the GitHub API.
  • It fetched and correctly processed 47 total items (41 Issues, 6 PRs).
  • Logic Verified: The start-date filter correctly identified and skipped issues created before 2022-06-15 (e.g., Issue Add Configuration File Validation and Error Handling #1739, Refactor Browser Detection #1392), confirming the configuration works as intended.
  • No actual changes were made to the repository due to debug mode.