Conversation
Collaborator
Author
|
Yay! Travis caught a problem with older Perls I didn't realize would be an issue. I'll fix it up tomorrow. |
Collaborator
Author
|
This branch is now good to go. @benbernard, would you take a look? |
|
|
||
| my $options = { | ||
| 'key|k=s' => sub { $this->{'KEYS'}->add_groups($_[1]) }, | ||
| 'format|f=s' => \($this->{'FORMAT'}), |
Owner
There was a problem hiding this comment.
I hadn't seen this ($hash->{key}) format before, cool!
Owner
|
Looks great! I had a few comments, but feel free to merge as-is |
Collaborator
Author
|
Thanks for the notes! I'll make the changes you recommended and merge away. |
Collaborator
Author
|
In adding some tests, I just found a bug (timezones, naturally), so I'm going to fix that and repush at some point (probably not today). |
Owner
|
awesome, glad you found it! On Sun, Feb 28, 2016 at 11:53 AM Thomas Sibley notifications@github.com
|
Naming tests is often very helpful in debugging to ensure you're looking at the right thing and to more quickly get a sense of what's broken.
Basically a front-end to Time::ParseDate, which offers more control than Date::Manip::DM5's ParseDate(). The fatpack recs, already 7.4MB, is increased only 28KB by Time::ParseDate, so there's no huge loss to avoid it. POSIX, luckily, is part of core.
benbernard
added a commit
that referenced
this pull request
Feb 22, 2026
Fix #71: Unicode/newline handling in totable and toptable - Use string-width package for proper visual width of CJK chars and emoji - Escape newlines, tabs, and backslashes in table cell values Fix #81: Add --only flag to decollate - New -o/--only option outputs only deaggregated fields, excluding original record fields Fix #59: Add file output to multiplex - New --output-file-key/-o and --output-file-eval/-O options - Supports {{key}} interpolation in file paths - Creates directories automatically Fix #86: Add fromxls input operation - Reads xls/xlsx/xlsb/xlsm files using xlsx library - Supports --sheet, --all-sheets, --no-header, --key/--field options Implement parsedate operation (closes PR #74) - TypeScript implementation of the parsedate transform from the old Perl PR - Supports --key, --output, --format, --output-format, --epoch, --output-epoch, --timezone options - Custom strftime-compatible parsing and formatting Fix #65: Add empty stream tests for collate - Confirms collate handles empty input without crashing for all aggregator types (avg, count, sum, max, min) Update man pages, operation registry, dispatcher, and test counts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
8 tasks
Owner
Superseded by TypeScript ImplementationA TypeScript implementation of
This PR can be closed once #90 is merged. |
benbernard
added a commit
that referenced
this pull request
Feb 23, 2026
Fix #71: Unicode/newline handling in totable and toptable - Use string-width package for proper visual width of CJK chars and emoji - Escape newlines, tabs, and backslashes in table cell values Fix #81: Add --only flag to decollate - New -o/--only option outputs only deaggregated fields, excluding original record fields Fix #59: Add file output to multiplex - New --output-file-key/-o and --output-file-eval/-O options - Supports {{key}} interpolation in file paths - Creates directories automatically Fix #86: Add fromxls input operation - Reads xls/xlsx/xlsb/xlsm files using xlsx library - Supports --sheet, --all-sheets, --no-header, --key/--field options Implement parsedate operation (closes PR #74) - TypeScript implementation of the parsedate transform from the old Perl PR - Supports --key, --output, --format, --output-format, --epoch, --output-epoch, --timezone options - Custom strftime-compatible parsing and formatting Fix #65: Add empty stream tests for collate - Confirms collate handles empty input without crashing for all aggregator types (avg, count, sum, max, min) Update man pages, operation registry, dispatcher, and test counts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically a front-end to Time::ParseDate, which offers more control than Date::Manip::DM5's
ParseDate(). The fatpack recs, already 7.4MB, is increased only 28KB by Time::ParseDate, so there's no huge loss to avoid it. POSIX, luckily, is part of core.