Added Windows compatibility to Gnuplot installation verification, also changed Exception name to PEP recomendations. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Sorry for the multiple times i've opened and closed this pull request. My cat walked over my laptop. |
Owner
|
Thanks for the addition, I think we will need to test it carefully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added Windows (nt) compatibility to the method I previously created to find if an installation of Gnuplot was made.
If you think all is ok, I would love a merge to the Master branch. (:
If you need help with any of this contributions (like retrocompatibility or anything), I surely be happy to help.