Avoid using String::leak in tests#55
Open
paolobarbolini wants to merge 2 commits intoberkowski:masterfrom
Open
Avoid using String::leak in tests#55paolobarbolini wants to merge 2 commits intoberkowski:masterfrom
String::leak in tests#55paolobarbolini wants to merge 2 commits intoberkowski:masterfrom
Conversation
paolobarbolini
force-pushed
the
tests-dont-leak
branch
from
42f19cb to
f8e9ba3
Compare
nemecec
added a commit
to nemecec/mio-serial
that referenced
this pull request
Feb 2, 2026
Replace leaked &'static str with owned String in test fixtures to eliminate memory leaks during test runs. Inspired by upstream PR berkowski#55.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged AFTER #56