handle edge case at the very last line of a file for "new_line_below"#32
Open
jsonjunkie wants to merge 1 commit intobernardo-bruning:mainfrom
Open
Conversation
Author
|
actually, im not sure if you want to merge this, im seeing it causes an error in the output (no other noticeable errors or crashes as a result)
it seems like there is some weirdness with the godot editor and the end of files in general |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kinda of mentioned in this issue #21 but when editing a file in the godot editor and the cursor is at the very last line, the "new_line_below" offset makes a new line above the current line
actual:


expected:

