Add SMTPS and SMTP AUTH support for EmailNotifier, through libcurl#34
Open
wandernauta wants to merge 1 commit intoberthubert:mainfrom
Open
Add SMTPS and SMTP AUTH support for EmailNotifier, through libcurl#34wandernauta wants to merge 1 commit intoberthubert:mainfrom
wandernauta wants to merge 1 commit intoberthubert:mainfrom
Conversation
This is intended as a compatible replacement of the existing email
notifier logic: setting 'server' to '10.0.0.2' will still open a SMTP
connection to port 25 on that host, and send the same message as before.
However...
- A hostname can now be given instead of an IP address.
- A port number other than 25 can now be provided.
- If the server hostname is prefixed with 'smtps://', we do TLS.
- If additionally a username and password are given, we do AUTH.
Combined, this looks something like:
smtps://myuser:mypassword@smtp.eu-west1.example.com:465
The new implementation (like the existing one) does not set a time-out,
but this could be added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended as a compatible replacement of the existing email notifier logic: setting 'server' to '10.0.0.2' will still open a SMTP connection to port 25 on that host, and send the same message as before. However...
Combined, this looks something like:
The new implementation (like the existing one) does not set a time-out, but this could be added.