Valiate request in dev mode for better debugging#19
Open
lichenglu wants to merge 1 commit intobetaacid:masterfrom
Open
Valiate request in dev mode for better debugging#19lichenglu wants to merge 1 commit intobetaacid:masterfrom
lichenglu wants to merge 1 commit intobetaacid:masterfrom
Conversation
ryanvanderpol
requested changes
Aug 15, 2018
Member
ryanvanderpol
left a comment
ryanvanderpol
left a comment
There was a problem hiding this comment.
hey @lichenglu thanks so much for the PR! I think this change is likely a good one, but there are so many formatting changes in this PR that I can't tell what changed. Please resubmit this PR without the formatting changes (quotes, indentation, etc.) so I can review and get it merged in. thanks!
Author
|
Ahh! Must be prettier. Will resubmit the PR tomorrow night. Thanks for reviewing! |
@lichenglu thanks for the PR, did you have time to work on it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the repo!
The pull request will add a feature for better debugging in dev mode (when
debugis set to true). This feature could potentially help prevent issues such as #14