Fix an issue that node name is incorrect if there is the source path#1
Open
spywo wants to merge 2 commits intobfosterjr:masterfrom
Open
Fix an issue that node name is incorrect if there is the source path#1spywo wants to merge 2 commits intobfosterjr:masterfrom
spywo wants to merge 2 commits intobfosterjr:masterfrom
Conversation
Graphviz doesn't like some special characters in node names.
The frame may or may not contain the source path if pdb is available. For example: "module!Class::method+0x1fd [C:\src\HelloWorld.cpp @ 2075]"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the pdb is available, the frame line contains the source path which needs to be removed prior to extract the node name.
Meanwhile, the node name may contain more special characters which are not supported by 'dot'. Quote the name resolves the issue.