ref: This is a general refactor to enhance readability and maintainability#68
Merged
antobinary merged 5 commits intobigbluebutton:v0.0.xfrom Aug 19, 2025
Merged
Conversation
Arthurk12
reviewed
Aug 19, 2025
Member
There was a problem hiding this comment.
The refactor looks good and indeed enhances the readability/maintainability of the code.
However I found 2 issues:
- I don't know if it was an issue before, but late joiners are prompted with the random picked user over the audio modal and session details modal. And the problem is that it gets into a state where the modal can't be closed. So the user is stuck.
- There is a warning being log into the console about app element not defined. Something related to modals too:
hook.js:608 Warning: react-modal: App element is not defined. Please use `Modal.setAppElement(el)` or set `appElement={el}`. This is needed so screen readers don't see main content when modal is opened. It is not recommended, but you can opt-out by setting `ariaHideApp={false}`. Error Component Stack
at ModalPortal (ModalPortal.js:79:5)
at Modal (Modal.js:73:5)
at P (styled-components.browser.esm.js:30:19658)
at PickUserModal (component.tsx:29:40)
at PickRandomUserPlugin (component.tsx:27:19)
Member
This is an issue today, without this PR |
ramonlsouza
approved these changes
Aug 19, 2025
Member
|
issue 2 also occurs without the PR (tested in local setup) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This basically refactors a bunch of functions/components to enhance readability and maintainability in the long term.
Apart for that refactor, I also renamed the labels for the filters in the presenter modal (and changed the logic accordingly).
This PR is made to maintain the whole plugin behaviour as is (except for the labels I mentioned), so if you find anything out of ordinary, please, let me know.
Closes Issue(s)
Closes #13
More
With this PR, the Presenter modal looks like (which is indeed better to grasp what each option does):