Skip to content

Conversation

@huanghuang358
Copy link
Contributor

Close #19 .

  1. Add setting button at both Welcome and Devicebar.
Welcome DeviceBar
image image
  1. Apply responsive design based on md: lg: 2xl: provided by unocss .
  2. Share screen button is disabled on mobile devices even though it is not hidden.
  3. More details can be found at the setting page.

Copy link
Contributor

@rocka rocka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks fine, better if remembered DRY (Don't Repeat Yourself)

@rocka
Copy link
Contributor

rocka commented Jun 30, 2025

Those setting values made me think that maybe we should switch to some centerialized store library, like https://github.com/pmndrs/zustand

Instead of passing onChangedDeviceVideo into the <Settings /> component, we read the store value by useStore and react on value changes by useEffect. Also it's more easy to save/restore the setting values to/from localStorage as a hole.

@huanghuang358
Copy link
Contributor Author

I think now all issues are resolved. Is there anything I can improve?

@rocka rocka merged commit 30fb407 into binbat:main Jul 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add setting page

2 participants