Skip to content

Conversation

@l0rinc
Copy link
Collaborator

@l0rinc l0rinc commented Apr 4, 2025

google/leveldb#819

In the iterator loop, call meta->largest.DecodeFrom(key) every time is unnecessary, which will copy every key to meta's largest field. We just need to copy the last key after the iteration is done.

@l0rinc l0rinc marked this pull request as draft April 4, 2025 10:49
@l0rinc l0rinc changed the title avoid unnecessary memory copy LevelDB: avoid unnecessary memory copy Apr 4, 2025
@github-actions
Copy link

github-actions bot commented Apr 4, 2025

📊 Benchmark results for this run (14263715610) will be available at: https://bitcoin-dev-tools.github.io/benchcoin/results/pr-159/14263715610/index.html after the github pages "build and deployment" action has completed.
🚀 Speedups: mainnet-default-uninstrumented: 1.7%, mainnet-large-uninstrumented: -0.1%

@willcl-ark willcl-ark force-pushed the master branch 7 times, most recently from d216dc5 to 7f7e173 Compare October 29, 2025 02:02
@willcl-ark willcl-ark force-pushed the master branch 4 times, most recently from fc55a9b to ec1c504 Compare December 9, 2025 16:25
@willcl-ark willcl-ark force-pushed the master branch 2 times, most recently from 5a6cd85 to d9d7b46 Compare December 10, 2025 09:45
@willcl-ark willcl-ark force-pushed the master branch 3 times, most recently from 44241cc to da1434a Compare December 30, 2025 05:30
@willcl-ark willcl-ark force-pushed the master branch 6 times, most recently from 623391b to 201f2eb Compare January 6, 2026 05:32
@willcl-ark willcl-ark force-pushed the master branch 11 times, most recently from 9252506 to aa46724 Compare January 13, 2026 02:53
@willcl-ark willcl-ark force-pushed the master branch 4 times, most recently from 2908ea8 to 5f20e15 Compare January 16, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants