Initial migration from TestNG to JUnit 5 by Knud-Aage · Pull Request #73 · bitrepository/reference

Knud-Aage · 2025-12-11T13:31:35Z

Added JUnit 5 annotations to BitrepositoryTestSuite
Added GlobalSuiteExtension to implement JUnit 5 extension points for suite-level setup and teardown.
Ensured consistency and correctness of test suite configuration and setup methods.

This commit updates the test suite configuration to use JUnit 5 annotations, allowing for more flexible and powerful test suite management.

It doesn't handle the TestNG @dependsOnGroups, because it collides with one of the principles of JUnit, which is that the test should run without depending on other tests.

- Added JUnit 5 annotations to BitrepositoryTestSuite - Added GlobalSuiteExtension to implement JUnit 5 extension points for suite-level setup and teardown. - Ensured consistency and correctness of test suite configuration and setup methods. This commit updates the test suite configuration to use JUnit 5 annotations, allowing for more flexible and powerful test suite management.

pom.xml

ole-v-v · 2025-12-12T10:46:55Z

...t/java/org/bitrepository/protocol/performancetest/MessageBusNumberOfListenersStressTest.java

@@ -39,9 +39,13 @@
 import org.bitrepository.protocol.security.SecurityManager;
 import org.bitrepository.settings.repositorysettings.MessageBusConfiguration;
 import org.jaccept.structure.ExtendedTestCase;


JAccept relies on TestNG. I got no idea whether we can get rid of both at the same time, or how great of an effort it would require. Ideally I think we would want to.

ole-v-v · 2025-12-12T10:52:20Z

...t/java/org/bitrepository/protocol/performancetest/MessageBusNumberOfListenersStressTest.java

 import org.testng.Assert;
-import org.testng.annotations.BeforeMethod;
-import org.testng.annotations.Test;
+//import org.testng.Assert;


Please delete rather than comment out.

pom.xml

ole-v-v · 2025-12-12T11:41:18Z

...t/java/org/bitrepository/protocol/performancetest/MessageBusNumberOfListenersStressTest.java

     */
-    @Test(groups = {"StressTest"})
+    @Test
+    @Tag("StressTest")


Yes, the way I read it this exactly the right substitute for TestNG groups.

ole-v-v · 2025-12-15T13:07:30Z

bitrepository-core/src/test/java/org/bitrepository/protocol/GlobalSuiteExtension.java

+                DEFAULT_DOWNLOAD_FILE_ADDRESS = DEFAULT_FILE_URL.toExternalForm();
+                DEFAULT_UPLOAD_FILE_ADDRESS = DEFAULT_FILE_URL.toExternalForm() + "-" + DEFAULT_FILE_ID;
+            } catch (MalformedURLException e) {
+                throw new RuntimeException("Never happens");


Allow me to suggest:

fail("Never happens", e);

I believe this will cause the test failure (although it never happens) to be clearer. At least somehow include the exception or its message in whatever we throw. If you like the RuntimeException better, you may chain the exception we’ve just caught:

throw new RuntimeException("Never happens", e);

(I just discovered you copied this code from the existing IntegrationTest class, so you may argue that improving the code is not part of this task.)

I added the exception to RuntimeException.

…-testng-with-junit

ole-v-v · 2025-12-15T13:17:58Z

bitrepository-core/src/test/java/org/bitrepository/protocol/BitrepositoryTestSuite.java

+ * </pre>
+ */
+@Suite
+@SelectClasses({IntegrationTest.class})  // List your test classes here


Are we sure what the effect of including an abstract TestNG test class as a class in a JUnit test suite is?

ole-v-v · 2025-12-15T13:20:19Z

bitrepository-core/src/test/java/org/bitrepository/protocol/BitrepositoryTestSuite.java

+ * public class BitrepositoryTestSuite {
+ *     // No need for methods here; this just groups and extends
+ * }
+ * }


Does doubling this line do something good?

Removed them and the public class BitrepositoryTestSutie above

ole-v-v · 2025-12-15T13:38:20Z

bitrepository-core/src/test/java/org/bitrepository/protocol/GlobalSuiteExtension.java

+     * May be extended by subclasses needing to have their receivers managed. Remember to still call
+     * <code>super.registerReceivers()</code> when overriding
+     */
+    protected void registerMessageReceivers() {


This method is not used?

In the IntegrationTest class where you copied it from, it is called from beforeMethod(). Should this copy be called from somewhere too?

There are more unused methods in this class.

ole-v-v · 2025-12-15T13:47:31Z

bitrepository-core/src/test/java/org/bitrepository/protocol/IntegrationTest.java

+        //
+    }
+
+    private void initializationMethod() {


If I read it correctly, you have moved the call to this method from "before suite" to "before class". Is this correct? Is it necessary?

ole-v-v · 2025-12-15T13:53:11Z

bitrepository-core/src/test/java/org/bitrepository/protocol/bus/ActiveMQMessageBusTest.java

        messageBus.sendMessage(messageToSend);
        Message receivedMessage = messageList.poll(3, TimeUnit.SECONDS);
-        assertEquals(receivedMessage.getStringProperty(ActiveMQMessageBus.MESSAGE_TO_KEY), receiverID);
+        Assertions.assertEquals(receivedMessage.getStringProperty(ActiveMQMessageBus.MESSAGE_TO_KEY), receiverID);  // Assertion update


If I am not mistaken, TestNG and JUnit have the arguments to assertEquals() in opposite orders. JUnit: assertEquals(expected, actual). TestNG: assertEquals(actual, expected). If so, you need to swap the arguments when exchanging one for the other. My suggestion:

Assertions.assertNotNull(receivedMessage); Assertions.assertEquals(receiverID, receivedMessage.getStringProperty(ActiveMQMessageBus.MESSAGE_TO_KEY));

The same argument swap applies everywhere, of course.

poll() may return null, so I added a check for that.

(I didn’t see the long-term value of the comment, so I left it out, but I may be missing something?)

ole-v-v · 2026-01-02T08:18:34Z

bitrepository-core/src/test/java/org/bitrepository/protocol/bus/ActiveMQMessageBusTest.java

-    @Test(groups = {"regressiontest"})
+    @Test
+    @Tag("regressiontest")
    public final void collectionFilterTest() throws Exception {


I am sorry, this is not working. When I do mvn package, this test is not being run. And when I run this test class from within IntelliJ IDEA, the tests fail.

ole-v-v · 2026-01-02T08:19:24Z

...t/java/org/bitrepository/protocol/performancetest/MessageBusNumberOfListenersStressTest.java

-    @Test(groups = {"StressTest"})
+    @Test
+    @Tag("StressTest")
    public void testManyListenersOnLocalMessageBus() throws Exception {


I am sorry, this is not working. When I do mvn package, this test is not being run. And when I run this test class from within IntelliJ IDEA, the tests fail.

ole-v-v · 2026-01-02T12:38:13Z

pom.xml

+          <artifactId>junit-platform-suite-engine</artifactId>
+          <version>1.10.3</version>  <!-- Match your JUnit version -->
+          <scope>test</scope>
+      </dependency>    <dependency>


Please fix the formatting and indentation of dependencies.

Knud-Aage requested review from Asger-KB and ole-v-v December 11, 2025 13:31

Knud-Aage self-assigned this Dec 11, 2025

ole-v-v reviewed Dec 12, 2025

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

ole-v-v reviewed Dec 12, 2025

View reviewed changes

ole-v-v reviewed Dec 15, 2025

View reviewed changes

Knud-Aage added 2 commits December 16, 2025 11:23

Merge remote-tracking branch 'origin/master' into BITMAG-1244-replace…

f50949f

…-testng-with-junit

Changes due to PR

7ec116c

ole-v-v requested changes Jan 2, 2026

View reviewed changes

ole-v-v reviewed Jan 2, 2026

View reviewed changes

Conversation

Knud-Aage commented Dec 11, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ole-v-v Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ole-v-v Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ole-v-v Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ole-v-v Dec 15, 2025 •

edited

Loading

ole-v-v Jan 2, 2026 •

edited

Loading

ole-v-v Jan 2, 2026 •

edited

Loading