Open
Conversation
This commit provides fixing of deprecation warnings because of Elixir version 1.9. Following changes were made: * Mix.Releases.Logger was replaced with Conform.Logger as there is no Mix.Releases.Logger anymore. * Mix.Dep.loaded/0 was replaced with Mix.Dep.load_on_environment/1 as the first one was deprecated and removed. * catch/rescue order fixed. The biggest change is in the test for creating archive with dependencies. Compliation of the fixtures projects was moved outside of Mix.Project.in_project/4 because previous behaviour was changed in the new Elixir and now it tries to build top-level (conform itself) dependencies instead of dependencies of fixture apps from conform/test directory. Mix.task.run is replaced with direct calling of `mix` tasks via System.cmd/2 to avoid these issues with dependencies and now everyting works as expected. This shouldn't break anything, because for normal Elixir project it works as expected as well.
Contributor
Author
|
Hello @bitwalker, I saw the deprecation notice, but can you take a look at this please as we heavily use conform in our internal projects and need in Elixir 1.9 as well. That should be no much to review as mostly warning fixes and the logic is not changed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit provides fixing of deprecation warnings because of Elixir
version 1.9.
Following changes were made:
no Mix.Releases.Logger anymore.
as the first one was deprecated and removed.
The biggest change is in the test for creating archive with dependencies.
Compliation of the fixtures projects was moved outside of
Mix.Project.in_project/4 because previous behaviour was changed in the
new Elixir and now it tries to build top-level (conform itself) dependencies
instead of dependencies of fixture apps from conform/test directory.
Mix.task.run is replaced with direct calling of
mixtasks via System.cmd/2to avoid these issues with dependencies and now everyting works as expected.
This shouldn't break anything, because for normal Elixir project it works
as expected as well.