Skip to content

[PM-16842] Pull down float value fix from upstream#20

Merged
coroiu merged 1 commit intomainfrom
coroiu/handle-float-values-deserialization
Jan 29, 2025
Merged

[PM-16842] Pull down float value fix from upstream#20
coroiu merged 1 commit intomainfrom
coroiu/handle-float-values-deserialization

Conversation

@coroiu
Copy link
Collaborator

@coroiu coroiu commented Jan 27, 2025

Merge pull request 1Password#43 from 1Password/progdrasil/handle-float-values-deserialization

Handle floating point values for deserialization

(cherry picked from commit cca6b24)

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

…t-values-deserialization

Handle floating point values for deserialization

(cherry picked from commit cca6b24)
@coroiu coroiu merged commit 3b76463 into main Jan 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants