Skip to content

Update idna version#22

Merged
coroiu merged 1 commit intomainfrom
ps/update-idna
Nov 10, 2025
Merged

Update idna version#22
coroiu merged 1 commit intomainfrom
ps/update-idna

Conversation

@dani-garcia
Copy link
Member

@dani-garcia dani-garcia commented Mar 4, 2025

🎟️ Tracking

📔 Objective

Update idna crate to fix a dependabot security alert:
https://github.com/bitwarden/passkey-rs/security/dependabot/10 (passkey-rs)
https://github.com/bitwarden/sdk-internal/security/dependabot/7 (sdk)

The change already exists upstream: 1Password@9b0edc8

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@dani-garcia dani-garcia marked this pull request as ready for review March 4, 2025 10:45
@dani-garcia dani-garcia requested a review from coroiu March 4, 2025 10:45
@coroiu coroiu merged commit 23e559f into main Nov 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants