Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
harr1424
left a comment
harr1424
left a comment
There was a problem hiding this comment.
Looks good overall! I've added some suggestions to update comments and also the return type you noticed on the call earlier.
There was a problem hiding this comment.
| /// Exporter related operations. | |
| pub fn sends(&self) -> ExporterClient { | |
| /// Send related operations. | |
| pub fn sends(&self) -> SendClient { |
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>
Co-authored-by: John Harrington <84741727+harr1424@users.noreply.github.com>
| pub struct SendAddEditRequest { | ||
| pub name: String, | ||
| pub notes: Option<String>, | ||
| pub key: Option<String>, |
There was a problem hiding this comment.
I don't think you can set a key when creating a send?
There was a problem hiding this comment.
In the case of a create this will be set to None, but for an edit it'll be set to Some(key)
|
|
||
| pub r#type: SendType, | ||
| pub file: Option<SendFileView>, | ||
| pub text: Option<SendTextView>, |
There was a problem hiding this comment.
We built the original Send and SendView models to be as compatible with existing TS data models. But similar to how Cipher is moving towards enums with associated data I think Sends can too since these are new APIs?
pub enum SendType {
File(SendFileView),
Text(SendTextView),
}and
pub enum SendAuthType {
None,
Password(String),
Emails(Vec<String>),
}Co-authored-by: John Harrington <84741727+harr1424@users.noreply.github.com>
|
4 participants
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-31067
📔 Objective
Add calls to the SendClient that adds/edits/gets/lists sends via API calls.
🚨 Breaking Changes