fix: catch csv.Error in estimate CSV loading#28
Merged
Conversation
Malformed CSV files (NUL bytes, parser corruption) would bubble up and crash startup instead of logging a warning and continuing without estimates. Restores graceful degradation for this optional input path.
bk86a
added a commit
that referenced
this pull request
Mar 12, 2026
fix: catch csv.Error in estimate CSV loading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
csv.Errorto the exception tuple in_load_estimates_from_csv()to restore graceful degradation for malformed CSV filesWithout this, a corrupt estimates CSV (NUL bytes, parser-level corruption) would bubble up and crash startup instead of logging a warning and continuing without estimates. Flagged by Codex review on PR #27.
Test plan
pytest tests/ -v— 69 tests passruff check app/— passes