Adding the logging to be done in a different goroutine #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
It's really not an issue - mutex is only matters when simultaneously invoke syslog and openlog functions. Syslog function is guarded via read lock that should allow multiple threads call this function without locking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I am very new to golang. So don't know if I have done something fundamentally wrong or utter useless change with this patch
I have made the sys logging to be done in a separate go routine thus (I think) eliminating the requirement to have a mutext on the Syslog function.
I /think this way of logging will be useful if you a running a REST API etc so that your app code (API request) will not wait on a mutext.