Add find and open func #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsjethani
force-pushed
the
add_FindAndOpen_func
branch
from
ee59344 to
d1acfaa
Compare
This function will lookup suitable webcam device and open it. IMO this is better than hardcoding `/dev/video0`.
rsjethani
force-pushed
the
add_FindAndOpen_func
branch
from
d1acfaa to
204ec01
Compare
Owner
|
Sorry for delayed response. I was a bit in disbelief on how to actually find if device is v4l2 device or not. Apparently there way is indeed to iterate over all "/dev/video*" devices. I'll gladly do a review of this PR then. |
Contributor
Author
|
@blackjack so you are saying that I should iterate only over video* devices? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FindAndOpen() func
This function will lookup suitable webcam device and open it. IMO this is better than hardcoding
/dev/video0.Addresses: Issue #27