Add quick-edit modal for referenced documents in Reference(s) fields#934
Closed
Add quick-edit modal for referenced documents in Reference(s) fields#934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ReferenceFieldandReferencesFieldso editors can edit referenced docs without leaving the current page.Description
ReferenceFieldEditorModalcomponent and stylesheet to load a referenced doc into an in-memory draft controller and allow saving updates back to the draft Firestore doc while updating local cache.ReferenceFieldandReferencesField, passing aquickEditDocIdto the modal and opening it when a reference preview/card is clicked with a normal left-click (modifier keys still open the doc in a new tab).ReferenceField.PreviewandReferenceField.DocCardto accept and call anonOpenQuickEditcallback, and prevent default link navigation when opening the modal; addrel="noopener noreferrer"to external links.DocPreviewCardin a clickable container forReferencesFieldand add a small CSS tweak (ReferencesField__card__previewCard) to restore previous padding; also add a trailing newline inReferenceField.css.InMemoryDraftDocControllerconstructor acceptrootKey: string | nulland treatnullas using the supplied value as-is, which enables using the controller with a root object likefields.Testing
yarn testand the tests passed.yarn buildwhich completed successfully.yarn lint/tscand they passed.Codex Task