Add _created and _updated metalables #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds new metadata fields (_created and _updated) to entities and updates related validations, storage, CLI presentation, and tests.
- Adds getter functions for _created and _updated in the entity model
- Updates validation logic and tests to account for the new metalabels
- Adjusts the CLI output and store operations to handle human-readable timestamps
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| etre.go | Adds _created/_updated constants and getter methods to expose timestamps |
| es/es.go | Converts metalabel timestamps to RFC3339Nano for CLI output |
| entity/validate*.go | Updates validations and tests to reject metalabels on creation |
| entity/v09_test.go | Adjusts tests to include the new metalabels |
| entity/store*.go | Integrates _created/_updated handling in creation and update operations |
| client_test.go & api/* | Updates tests to correctly convert and verify new timestamp metalabels |
daniel-nichter
approved these changes
Jun 4, 2025
qian-squareup
approved these changes
Jun 4, 2025
wen-hui-sun
approved these changes
Jun 4, 2025
The code change itself is relatively small and straightforward: * Add the new metalable in etre.go * Add the validations in validate.go * Maintain the label in store.go * Update the CLI to pretty-print in a human readable form (instead of the raw Unix nano time) The test changes were more involved, particularly because the timestamps are not deterministic. Most of the tests that validate actual data now follow a pattern where they put the actual values into the expected entity for the assert.Equal(t, expected, actual), and then do a separate check that the actual time is a realistic value (in the last few seconds). Also fixed a bug with Entity.Rev(). It expected an int type, but json.Unmarshal sets it to a float64 which caused a panic. Now that is fixed to allow the various int flavors _and_ float.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code change itself is relatively small and straightforward:
The test changes were more involved, particularly because the timestamps are not deterministic. Most of the tests that validate actual data now follow a pattern where they put the actual values into the expected entity for the assert.Equal(t, expected, actual), and then do a separate check that the actual time is a realistic value (in the last few seconds).
Also fixed a bug with Entity.Rev(). It expected an int type, but json.Unmarshal sets it to a float64 which caused a panic. Now that is fixed to allow the various int flavors and float.