Skip to content

Conversation

@qian-squareup
Copy link
Collaborator

@qian-squareup qian-squareup commented Jul 29, 2025

What and Why

Handle scenario where deleteLabelHandler return a nil Etre.Entity. This ensures that we're returning an error instead of a panic.

Testing

Confirmed that delete a required label now returns an error instead of panic.

Failed to delete label from elasticache_node 6884660f3c6561589dc92b5d: failed to update entity (db err: Document failed validation) (db-update-failed)

@qian-squareup qian-squareup merged commit fd6f706 into master Jul 31, 2025
2 checks passed
@qian-squareup qian-squareup deleted the qian/fixDeleteLabel branch July 31, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants