Handle ModuleFuelTanks nodes#235
Open
StonesmileGit wants to merge 4 commits intoblowfishpro:masterfrom
Open
Conversation
blowfishpro
reviewed
Oct 27, 2022
B9PartSwitch/PartSwitch/PartModifiers/ModuleFuelTanksHandler.cs
Outdated
Show resolved
Hide resolved
B9PartSwitch/PartSwitch/PartModifiers/ModuleFuelTanksHandler.cs
Outdated
Show resolved
Hide resolved
StonesmileGit
commented
Oct 30, 2022
B9PartSwitch/PartSwitch/PartModifiers/ModuleFuelTanksHandler.cs
Outdated
Show resolved
Hide resolved
StonesmileGit
changed the title
Contributor
Author
|
I modified this PR to instead send an event to MFT with the entire node. That way we can parse everything more easily, and as a bonus any changes wouldn't need to go here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a direct adaptation of #183, since that has had no activity.
From the KSP-RO side, we only care about changing the tank volume, so this PR has been slightly scaled back from the original attempt.
Since the original PR is quite old, one question is if this is still the preferred way to add something like this, or if another method would be better. I would be happy to change over to another method.
Some of the changes suggested, but not implemented in the original PR has been added here, but there might still be some changes that should be made.