Open
Conversation
Contributor
|
@alcedoatthis this does not make any sense, without value from connected state you don't need onion form at all.. |
Author
|
@ondrejbartas Current api is kept, if You don't pass value as a prop to component. Is there any example of functionality mentioned? IMHO other options like hooking export default function connectField(fieldName, ..., mergeProps) {
return FieldComponent => {
@connect(
(state, { onionFormName }) => ({...}),
(dispatch, { onionFormName }) => ({...}),
mergeProps
) // ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful e.g. for check/uncheck all checkbox. Value can be combined from other values and passed directly to check-all checkbox. IMHO it is better to move
{...rest}props below others, but I'm not sure if this behaviour is wanted (?)