Skip to content

Conversation

@patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Jan 9, 2026

Summary by Sourcery

Bug Fixes:

  • Allow multiple or repeated Ping360 Ethernet probe runs to bind to the same UDP port without failing due to address-in-use errors.

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 9, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Configures the UDP broadcast socket used in ping360 Ethernet probing to allow address reuse on port 30303, improving robustness when multiple processes or previous sockets have bound the same port.

Sequence diagram for ping360 Ethernet probing with SO_REUSEADDR

sequenceDiagram
    participant PingProber as find_ping360_ethernet
    participant Socket as UDP_Socket
    participant Network as Local_Network

    PingProber->>Socket: socket(AF_INET, SOCK_DGRAM, IPPROTO_UDP)
    PingProber->>Socket: setsockopt(SOL_SOCKET, SO_BROADCAST, 1)
    PingProber->>Socket: setsockopt(SOL_SOCKET, SO_REUSEADDR, 1)
    PingProber->>Socket: settimeout(0.2)
    PingProber->>Socket: bind(0.0.0.0:30303)
    PingProber->>Network: sendto(broadcast, port 30303)
    Network-->>PingProber: replies from Ping360 devices
    PingProber->>Socket: close()
Loading

File-Level Changes

Change Details Files
Allow UDP probe socket to reuse the broadcast port when scanning for Ping360 Ethernet devices.
  • Add SO_REUSEADDR option to the UDP socket used for broadcasting discovery packets
  • Keep existing broadcast configuration and timeout behavior unchanged
core/services/ping/ping360_ethernet_prober.py

Possibly linked issues

  • #(unassigned): PR partially implements the issue by adding SO_REUSEADDR for the ping360_ethernet_prober socket on port 30303.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@joaomariolago joaomariolago merged commit 39496ec into bluerobotics:master Jan 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants