Fix JSON tag casing, error handling, and documentation inconsistencies from PR #73 review#74
Merged
kellrott merged 4 commits intorefactor/output-sectionfrom Feb 19, 2026
Merged
Conversation
…sDir method, and doc typos Co-authored-by: kellrott <113868+kellrott@users.noreply.github.com>
Co-authored-by: kellrott <113868+kellrott@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor playbook file format to use common output section
Fix JSON tag casing, error handling, and documentation inconsistencies from PR #73 review
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review comments from PR #73 on the playbook refactoring work. Fixes struct tag mismatches that would break YAML unmarshaling, improves file I/O error handling, and corrects documentation to match the new
params-based format.Changes
Extractor struct tags - Changed
json:"Path"tojson:"path"in:extractors/tabular_load.goextractors/sqldump_step.goPreviously capitalized tags would fail to unmarshal playbooks using lowercase
path:keys.ReadAt error handling - Fixed
extractors/transpose_load.go:IsDir() type checking - Updated
config/config.goto recognize both"dir"and"path"types:Documentation corrections:
docs/docs/config.mdvalue:todefault:in example yaml indocs/docs/inputs/index.mdinput→pathindocs/docs/schema.md✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.