Modernize Docker Stack, Add CI/CD, and Fix Monitor Compatibility #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve PostgreSQL and Osmosis setup.
…atabase, refine PostgreSQL and Osmosis setup.
…t variables, healthcheck, and volume mappings.
…t and database, refine PostgreSQL and Osmosis setup.
…t and database, refine PostgreSQL and Osmosis setup.
…s.maxsize`, update file handling to binary mode, and ensure UTF-8 decoding for socket data.
…with Maven base image and map properties - Introduce `docker-entrypoint.sh` to dynamically configure `server.properties` and `map.properties` from environment variables. - Replace base image in `Dockerfile` with Maven for a more streamlined build process. - Update `docker-compose.yml`: - Switch `matcher-server` to build from context. - Add environment variables for map and server configurations. - Introduce healthcheck dependency for `map-server`. - Include default `map.properties` settings for database configuration.
…DE` environment variable.
- Update None checks with `any()` for better readability. - Replace deprecated `long` type with `float` in `isinstance()` call. - Use `input()` instead of `raw_input()` for compatibility with Python 3. - Align boolean comparisons with Python conventions.
…iguration - Replace `OSM_*` environment variables with `MAP_*` and `POSTGRES_*` conventions. - Update `docker-compose.yml`, `entrypoint.sh`, and `Dockerfile` for consistent variable usage. - Adjust import script execution parameters in the entrypoint script to reflect new variable names. - Improve clarity and maintainability of environment configurations.
- Split `Dockerfile` into separate files for matcher and tracker services. - Add `entrypoint.sh` scripts to dynamically configure properties for matcher and tracker servers. - Update `docker-compose.yml`: - Reference new Dockerfiles for matcher and tracker services. - Add tracker server configuration with port mappings and environment variables. - Ensure default properties for server, map, and tracker configurations.
…oved readability
…age subscription to async/await ensuting compatibility with node 20.
…e configuration and automatic map import, replacing static region property files.
… a separate compose file for local builds from source.
…EADME instructions, and add path filtering to Docker publish workflow.
…r updates in TrackerServer
…ctories from Docker builds
…ith `docker compose`
…hem in GeoJSONOutputFormatter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Modernize Docker Stack, Add CI/CD, and Fix Monitor Compatibility
Description
This PR introduces a significant overhaul to the deployment and development experience of Barefoot, focusing on containerization, configuration flexibility, and modern tooling compatibility.
Key Changes
1. Docker Modernization
map,matcher, andtrackerservices.docker-compose.ymlto use pre-built images from GitHub Container Registry (GHCR) by default. This allows users to start the stack immediately without local compilation.docker-compose.build.ymlfor users who need to build from source.2. Dynamic Configuration
SERVER__PORT,MAP__DATABASE_HOST) toserver.propertiesandmap.propertiesat runtime.3. CI/CD Pipeline
docker-publish.ymlworkflow that automatically builds and publishes Docker images to GHCR.src,map,docker, etc.) are modified.4. Monitor Tool Fixes
barefoot-monitordependency fromzmq(which had native binding issues on newer Node versions) tozeromq.monitor.jsto use the newzeromqasync/await API, ensuring compatibility with Node.js 20+.5. Documentation
README.mdwith a "Docker Ready" section, providing clear instructions on how to run the stack and configure it using environment variables.Motivation & Advantages
docker-compose up -dand have a fully functional map-matching stack in minutes.