Open
Conversation
Owner
|
What an awesome PR from a repo I forgot even existed @mcbobby123! There are some code-style changes I would like to keep in place. Given this is the first PR to this repo and you and I have never worked together, would you prefer I leave that feedback for you or make the changes myself? Thanks again though, really excited to see this repo updated and new functionality added! |
Author
|
Just let me know what code style changes should be made and I'll try fix it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a few command-line options.
-vto show the joke id--id [id]to fetch a specific jokesearch [term] --page [page = 1] --limit [limit = 20]to search for jokesalso switched from request to node-fetch