"Fix" custom error messages on more recent versions of Node#15
Open
myndzi wants to merge 1 commit intobodenr:masterfrom
Open
"Fix" custom error messages on more recent versions of Node#15myndzi wants to merge 1 commit intobodenr:masterfrom
myndzi wants to merge 1 commit intobodenr:masterfrom
Conversation
Owner
|
@myndzi thanks for this report and merge request. It appears there's already a node issue for this: nodejs/node#5675 In the meantime I have no problems merging your "workaround". However can I ask one thing -- would you mind just adding a TODO comment with a link to the node bug so that we can easily identify the root cause? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs here: https://nodejs.org/api/errors.html#errors_error_capturestacktrace_targetobject_constructoropt
claim that the target of the
captureStackTracemethod's.toStringmethod will be used to generate the error message line, but it doesn't seem to be so, at least on versions 5.3 and 5.9.1. Instead, just the vague string 'Error' is produced. This patch will replace either 'Error' or '[Object object]' at the start of the line with the custom message, instead of just '[Object object]'. It's worth noting that the test suite fails on recent versions of nodes for this reason, so I didn't need to add any tests to validate this patch -- they are already there.Closes #14