Flake8 fixes #5
Merged
Flake8 fixes #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Best to go with upstream defaults where appropriate to avoid surprising the user.
auraesteban
approved these changes
Feb 4, 2025
Owner
Author
|
Thanks Aura. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run flake8 as part of GitHub Actions, so it make sense to also run it from the appropriate Makefile target.
Additionally, this removes an
--ignore=directive, since we should not presume to know what the user may want. This is especially true for E203, where there should be no concern regarding incompatibility with other formatting tools such as black.