Fix openscop scattering dimension parsing error #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zetsyog
changed the title
bondhugula
reviewed
Mar 16, 2025
Owner
I now notice the input is in openscop format and so we'll need a different testing mechanism than the current tests. |
bondhugula
reviewed
Mar 16, 2025
bondhugula
reviewed
Mar 16, 2025
bondhugula
reviewed
Mar 16, 2025
…ator and dimension counts
Zetsyog
commented
Mar 18, 2025
Author
Zetsyog
left a comment
Zetsyog
left a comment
There was a problem hiding this comment.
I also noticed that lots of scripts are using /bin/bash as shebang. Using /usr/bin/env bash is more portable. Can I add this change in this PR or should I create another one ?
bondhugula
approved these changes
Mar 19, 2025
Owner
bondhugula
left a comment
bondhugula
left a comment
There was a problem hiding this comment.
LGTM - thanks. Please squash fixup commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using openscop as input for pluto that is not straight out from clan, pluto is failing.
See the example with the following scop file.
input.scop.txt
Pluto compute the number of scattering dimension as
2 * niter + 1(with niter being the number of iterators of the statement)This is true when the openscop is extracted from clan, but not always true.
The OpenScop Library provides the
osl_relation_get_attributesfunction to retrieve the numder of iterators and scattering dimensions which fixes the issue.