Fix openscop to pluto prog conversion #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bondhugula
reviewed
Mar 26, 2025
Owner
bondhugula
left a comment
bondhugula
left a comment
There was a problem hiding this comment.
Can you please add the test case? See the recent commit on the main branch for reference: d758ec1
bondhugula
reviewed
Mar 26, 2025
Owner
bondhugula
left a comment
bondhugula
left a comment
There was a problem hiding this comment.
Please clang-format. See contribution instructions.
bondhugula
reviewed
Mar 26, 2025
Owner
bondhugula
left a comment
bondhugula
left a comment
There was a problem hiding this comment.
Thank you for fixing this. It'll be good to have the test case added.
Nawreua
force-pushed
the
osl-conversion-fix
branch
from
8349507 to
8770d05
Compare
Owner
|
The two added tests fail in the automation - can be reproduced with |
Owner
You'll need to add some a CHECK line at least. |
bondhugula
reviewed
Apr 20, 2025
Comment on lines
+227
to
+229
| @top_srcdir@/test/gemver.scop \ | ||
| @top_srcdir@/test/simple-case-verification.scop \ | ||
| @top_srcdir@/test/simple-case-computation.scop \ |
Owner
There was a problem hiding this comment.
These scop files need to have at least one CHECK line comment of the expected output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to convert openscop inputs to pluto progs, missing breaks caused pluto to incorrectly assign dependencies as undefined and a missing verification caused a null pointer exception when trying to convert an empty scop.