Conversation
Update master
interface, numpy, pandas, requests, ujson
Contributor
Author
|
Location code parsing, retrieval, and storage |
Reset tinydb before write Add TODO for alternative save/db implementations
Performance improved thousands of times
Contributor
Author
|
Improved performance with bulk-write operation |
Move to model/location_codes.py
Move to model/location_codes.py Having it in a separate file was over-engineering
Moved functionality to model/location_codes to simplify
Plan to create tinydb repo instead
LocationCodes can be greatly simplified since isn't too large to need to be saved to a repo, purpose is intermediary model to pass on to ValidCodes
Interface for repositories (e.g. databases)
Minimal implementation of a tinydb repo
Contributor
Author
|
Move files to realestate submodule dir
|
Save codes to json in /data data/code_combinations.json is too large -- ~250 MB, need to refactor to use generators Approx number of code combinations by location type (whether valid or invalid): State - 5.5k Metro - 96,9k County - 621k City - 2.8 million Neighborhood - 1.7 million Zipcode - 10.6 million
~250mb code_combinations.json exceeds github 100mb limit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.