feat: gracefully handle shutdown signals #1577
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was having trouble generating code coverage for my tests with
nyc.Took me some time but I found out that
nycrequires the process it spawn to gracefully exit.I was not completely sure what that meant, so I had to do some digging.
This PR adds handling of signals to gracefully shut down the process.
Changes
Checks
Additional information
I added a
cleanup()function that is currently empty, question is: does Booster have dedicated functions to close down the server, clean data, close connections ?Didn't add docs on the functions as I find them self explanatory.
This fixes the issue for me locally, but I am not entirely sure if this is the way to go. (approach + location in Booster code itself)
Does this require any documentation to be updated ?