CMakeLists.txt: use GAS by default if building with Clang-CL #328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if (MSVC)evaluates to true if building with Clang-CL, but at least if cross-compiling with Clang-CL from a non-Windows host, MASM (default for MSVC) is not understood. Using GAS, however, works perfectly. I therefore propose to restrict this check to trigger only with MSVC and not Clang-CL. I have not tested this extensively, but it works in my case where I use Clang-CL on a GNU/Linux host targeting Windows.Of course another option is to override the detected assembler using
-DBOOST_CONTEXT_ASSEMBLER="gas", but automatic detection makes build scripts a bit cleaner.