Merged
Conversation
cmazakas
force-pushed
the
feature/xxh3-128
branch
4 times, most recently
from
dd4c195 to
84b3a49
Compare
cmazakas
force-pushed
the
feature/xxh3-128
branch
from
84b3a49 to
6b24415
Compare
cmazakas
force-pushed
the
feature/xxh3-128
branch
from
6b24415 to
d66dcba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had trouble with some of the tests.
By definition, xxh3-128 is stateless for the empy string so I wasn't sure how to satisfy the requirement that
h.result(); h.result();yields different values.