Conversation
🦋 Changeset detectedLatest commit: 60fd09a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
…riablecriteriaincentivev2-being-typed-and-treated-as-v1-in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
V1 and V2 variable criteria incentives share the same interfaceId. This previously led to misidentification issues, for instance, when an incentive was retrieved (e.g., via
getBoostor similar mechanisms relying onincentiveFromAddress).As a result, a V2 incentive might have been incorrectly identified as V1, causing checks like
incentive instanceof ERC20VariableCriteriaIncentiveV2to returnfalseeven for a true V2 instance.This change resolves the ambiguity by introducing a V2-specific read operation when an incentive with the shared interfaceId is encountered. This read is designed to succeed exclusively for V2 contracts. Based on the outcome of this operation (success for V2, failure for V1), the appropriate SDK class for the incentive is now reliably instantiated.
Tests have been added to verify that each incentive type is correctly identified and instantiated by
incentiveFromAddress.