Draft
Conversation
mmackz
commented
Oct 30, 2024
| </Expandable> | ||
| </ParamField> | ||
|
|
||
| <WriteParams /> |
Contributor
Author
There was a problem hiding this comment.
Also uses DeployableOptions. 🤔
Contributor
There was a problem hiding this comment.
good callout, i'll make a note to remove deployable options, i think i had it tuped that way before i understood cloning/init and was deploying more contracts during create
sammccord
reviewed
Oct 31, 2024
| <ParamField path="allowList" type={<a href="https://boost-protocol.vercel.app/types/AllowList.html">AllowList</a>} /> | ||
| <ParamField path="incentives" type={<a href="https://boost-protocol.vercel.app/types/Incentive.html">Incentive[]</a>} required /> | ||
| <ParamField path="protocolFee" type="bigint" /> | ||
| <ParamField path="maxParticipants" type="bigint" /> |
Contributor
There was a problem hiding this comment.
not sure if best place for it is here, but we need somewhere prominent to point out that budgets will transfer a multiple of maxParticipants worth of assets into the incentive, it can be confusing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core.createBoost().Need to add better descriptions and link out to other pages (once they are created)
Looking for feedback mostly before I go further into the examples.