Open
Conversation
8f0437e to
7a99a63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
We use the pretty useful Pipeline Maven Integration plugin to run Maven jobs. One of its features is that when you wrap your Maven execution with
withMaven, which the plugin provides, it spies on the generated artifacts and then stores their GAV in a DB. Thanks to that information it's then able to trigger downstream SNAPSHOT projects on the same instance automatically. This is vital in our setup but we also very much enjoy what the SDP Maven library offers out of the box, so we thought to add support for the plugin right here.Description
The PR adds an optional
withMavenParamsfield to the step configuration. As soon as the map contains a property, and only if the map contains anything, the Maven invocation is then wrapped with thewithMavenstep (which requires the plugin to be installed).How Has This Been Tested
I have configured a local Jenkins instance to use my fork of the libraries and confirmed that defining this parameter wraps the Maven execution with
withMaven, whereas not defining it leaves the build unchanged.Types of Changes
Checklist