Open
Conversation
This allows you to screenshare to a rM that is not on the same subnet as the rmview client. rM's UDP broadcast messages are obtained from the rM device itself. * autoinstall changes to get a decent netcat (nc.traditional) * replace ChallengeReaderProtocol with ssh+netcat
Contributor
|
It's a little concerning that there is no way to verify the validity of the "traditional unix netcat" binary you included in this PR. I would not be comfortable myself merging this as-is, and I'd instead want to have the source of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if others are interested in this, but I wanted to screen share with a rM device on a separate subnet that could not directly receive the UDP broadcasts from the rM. I made this change to help me do that. It's a little bit of an invasive change, but basically it ssh-es to the rM and uses netcat to listen for the UDP broadcasts on the device itself. Unfortunately the version of netcat already on the rM is hobbled, so I added the logic to install a traditional unix netcat. Do with it what you will.