Skip to content
This repository was archived by the owner on Dec 24, 2025. It is now read-only.

Comments

Github Actions Gitflow and Dockerizing#270

Open
burakcankazim wants to merge 9 commits intomasterfrom
dev/ci-cd
Open

Github Actions Gitflow and Dockerizing#270
burakcankazim wants to merge 9 commits intomasterfrom
dev/ci-cd

Conversation

@burakcankazim
Copy link
Collaborator

No description provided.

@veyisTurgut
Copy link
Collaborator

This is great but what about frontend?
Are they going to deploy it themselves?

Copy link
Collaborator

@veyisTurgut veyisTurgut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait merging until I configure mail address-password to github Secrets. We can put that to environment tab in docker-compose.yml

@burakcankazim
Copy link
Collaborator Author

Secrets that are currently used in the workflow are already setup. And I will set up the frontend after I learn about how are they deploying their app.

@veyisTurgut
Copy link
Collaborator

  • Then, we can wait until frontend to finish to merge to master.
  • By the way, we have new Secrets in Github. Please add them to docker-compose.yml as environment variables of Spring app.
    They are:
    • spring_mail_password
    • spring_mail_username
    • spring_jwt_secretKey

@burakcankazim
Copy link
Collaborator Author

Oh by the way do we need username and password for the database too as secrets?

@veyisTurgut
Copy link
Collaborator

password MUST be a secret. name also should be a secret I guess.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants