Conversation
bdebinska
left a comment
There was a problem hiding this comment.
Looks good, a couple of things related to this PR:
The comment in this line should be changed: https://github.com/box-id/workflow_engine/blob/main/lib/actions/action.ex#L4
It would be nice to provide the actual github ssh links here, so that we can just copy them over:
https://github.com/box-id/workflow_engine_actions/blob/main/README.md?plain=1#L25
Do the actions need to be nested in the lib/actions? They could just live in the lib IMO https://github.com/box-id/workflow_engine_actions/tree/main/lib/actions
Do we use this anywhere?
https://github.com/box-id/workflow_engine_actions/blob/main/mix.exs#L35
Good catch
The variant in the Readme should work now, until the workflow_engine PR is done and the tag 2.0.0 is created.
I'm fine with both, so I removed the subfolder.
I already found this before, but it wasn't yet pushed ;-) |
No description provided.