feat: Replace @oclif/command to @oclif/core library
#553
Conversation
…o drop-support-node
| fs.unlinkSync(downloadedFilePath); | ||
| /* eslint-enable no-sync */ | ||
| assert.ok(downloadContent.equals(expectedContent)); | ||
| let expectedMessage = getDownloadProgressBar(295191); | ||
| let expectedMessage = getDownloadProgressBar(testFileStat.size); |
There was a problem hiding this comment.
Changing line endings from CLRF to LF for the epic-poem.txt fixes this test for me locally without your changes. Could that be the issue? Maybe the repo was cloned with windows line endings?
Anyway, I think your approach is better as it should work regardless of the line endings, but we should somehow explain why it's done this way as it's not obvious from the code (either by extracting some parts to a named function or leaving a comment at least)
Pull Request Test Coverage Report for Build 13012256321Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
mwwoda
left a comment
mwwoda
left a comment
There was a problem hiding this comment.
Great job! Mostly comments about the cleanup of unused vars I see that you did it in some places.
| "eslint-plugin-n": "^17.14.0", | ||
| "eslint-plugin-promise": "^7.2.1", | ||
| "eslint-plugin-unicorn": "^5.0.0", | ||
| "generate-license-file": "^3.6.0", |
| class MetadataTemplatesListCommand extends BoxCommand { | ||
| async run() { | ||
| const { flags, args } = this.parse(MetadataTemplatesListCommand); | ||
| await this.parse(MetadataTemplatesListCommand); |
There was a problem hiding this comment.
do we need to parse it at all?
There was a problem hiding this comment.
After brief discussion: We're not sure if it would affect anything (if this function is only parsing input params). We decided to keep it for now as it's not that big of a deal.
No description provided.