Skip to content

Conversation

@arjankowski
Copy link
Contributor

This PR resolves ESLint warnings across the codebase ensuring a clean npm run lint state:

  • replace obj.hasOwnProperty() with the safer Object.hasOwn() across all modules and commands
  • replace complex Array#reduce calls with Object.assign spreads or simple loops (rule unicorn/no-array-reduce)
  • switch Array#concat usage to the spread operator (rule unicorn/prefer-spread)
  • decouple member access from await expressions for clearer debugging (rule unicorn/no-await-expression-member)
  • Silence intentional test-skip warnings in tokens.test.js

@arjankowski arjankowski requested a review from a team January 2, 2026 15:26
@coveralls
Copy link

Pull Request Test Coverage Report for Build 20660931664

Details

  • 67 of 74 (90.54%) changed or added relevant lines in 33 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 85.543%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commands/configure/environments/add.js 0 1 0.0%
src/commands/configure/environments/delete.js 0 1 0.0%
src/commands/configure/environments/set-current.js 0 1 0.0%
src/commands/configure/environments/update.js 0 1 0.0%
src/commands/configure/settings.js 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/commands/files/zip.js 1 81.03%
Totals Coverage Status
Change from base Build 20616794354: -0.04%
Covered Lines: 4732
Relevant Lines: 5332

💛 - Coveralls

Copy link

@KwiatkowskiML KwiatkowskiML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjankowski arjankowski merged commit a8c5632 into main Jan 5, 2026
17 checks passed
@arjankowski arjankowski deleted the lint_fixes branch January 5, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants